chore(rendering): remove the Clamp Lighting effect - #85
Conversation
MovingBlocks/Terasology#5152: Clamp Lighting was reported to visibly do nothing. Investigated and confirmed: it clamps this pass's output color to [0.0, 1.0] before later HDR-aware post-processing (bloom, eye adaptation, tone mapping) runs on it. Most framebuffer formats already clamp on write regardless, so the setting only has a visible effect in specific HDR configurations - not a bug, a setting whose effect never showed up where a player toggling it would look. The maintainer who looked into it asked for outright removal rather than a fix: "remove clamplightning in both ui and Rendering Config." Dropped the #if defined(CLAMP_LIGHTING) branch, keeping the unclamped path - the engine's default.cfg already had it off by default, so this is the behaviour every player already saw. Also drops the doc section and its screenshot, which was the only other reference to the setting in this repo. Companion change removing the config/UI side in the engine repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ran a visual/log test with this change (plus the rest of a larger merge-train batch) using the full Omega module set, then compared its Both runs produce the exact same 231 So this DAG noise is pre-existing in |
1 participant
Part of MovingBlocks/Terasology#5152.
Clamp Lighting was reported to visibly do nothing. It clamps this pass's output color to
[0.0, 1.0]before later HDR-aware post-processing (bloom, eye adaptation, tone mapping) runs on it. Most framebuffer formats already clamp on write regardless, so the setting only has a visible effect in specific HDR configurations - which is why toggling it did nothing for most players in practice. The maintainer who investigated asked for outright removal rather than a fix: "remove clamplightning in both ui and Rendering Config."Drops the
#if defined(CLAMP_LIGHTING)branch, keeping the unclamped path - the engine'sdefault.cfgalready had the setting off by default, so this is the behaviour every player already saw. Also drops the doc section and its screenshot, the only other reference to the setting in this repo.Companion PR
The config/UI side lives in the engine repo: MovingBlocks/Terasology#5370